diff options
Diffstat (limited to 'backend/pk-backend-slack.cc')
| -rw-r--r-- | backend/pk-backend-slack.cc | 397 |
1 files changed, 175 insertions, 222 deletions
diff --git a/backend/pk-backend-slack.cc b/backend/pk-backend-slack.cc index 7e04866..322ee1d 100644 --- a/backend/pk-backend-slack.cc +++ b/backend/pk-backend-slack.cc @@ -1,6 +1,12 @@ +/* + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at https://mozilla.org/MPL/2.0/. + */ #include <dirent.h> #include <glib/gstdio.h> #include <packagekit-glib2/pk-debug.h> +#include <cstdint> #include <stdlib.h> #include <stdio.h> #include <zlib.h> @@ -15,19 +21,19 @@ using namespace slack; -static GSList *repos = NULL; +static GSList *repos = nullptr; void pk_backend_initialize(GKeyFile *conf, PkBackend *backend) { - gchar *path, **groups; - gint ret; + char *path, **groups; + int ret; gushort i; gsize groups_len; GFile *conf_file; GFileInfo *file_info; GKeyFile *key_conf; - GError *err = NULL; - gpointer repo = NULL; + GError *err = nullptr; + void *repo = nullptr; sqlite3 *db; sqlite3_stmt *stmt; @@ -35,7 +41,7 @@ void pk_backend_initialize(GKeyFile *conf, PkBackend *backend) curl_global_init(CURL_GLOBAL_DEFAULT); /* Open the database. We will need it to save the time the configuration file was last modified. */ - path = g_build_filename(LOCALSTATEDIR, "cache", "PackageKit", "metadata", "metadata.db", NULL); + path = g_build_filename(LOCALSTATEDIR, "cache", "PackageKit", "metadata", "metadata.db", nullptr); if (sqlite3_open(path, &db) != SQLITE_OK) { g_error("%s: %s", path, sqlite3_errmsg(db)); @@ -44,7 +50,7 @@ void pk_backend_initialize(GKeyFile *conf, PkBackend *backend) /* Read the configuration file */ key_conf = g_key_file_new(); - path = g_build_filename(SYSCONFDIR, "PackageKit", "Slackware.conf", NULL); + path = g_build_filename(SYSCONFDIR, "PackageKit", "Slackware.conf", nullptr); g_key_file_load_from_file(key_conf, path, G_KEY_FILE_NONE, &err); if (err) { @@ -56,7 +62,7 @@ void pk_backend_initialize(GKeyFile *conf, PkBackend *backend) if (!(file_info = g_file_query_info(conf_file, "time::modified-usec", G_FILE_QUERY_INFO_NOFOLLOW_SYMLINKS, - NULL, + nullptr, &err))) { g_error("%s", err->message); @@ -67,7 +73,7 @@ void pk_backend_initialize(GKeyFile *conf, PkBackend *backend) "UPDATE cache_info SET value = ? WHERE key LIKE 'last_modification'", -1, &stmt, - NULL)) == SQLITE_OK) { + nullptr)) == SQLITE_OK) { ret = sqlite3_bind_int(stmt, 1, g_file_info_get_attribute_uint32(file_info, "time::modified-usec")); if (ret == SQLITE_OK) { @@ -93,18 +99,18 @@ void pk_backend_initialize(GKeyFile *conf, PkBackend *backend) groups = g_key_file_get_groups(key_conf, &groups_len); for (i = 0; i < groups_len; i++) { - gchar *blacklist = g_key_file_get_string(key_conf, groups[i], "Blacklist", NULL); - gchar *mirror = g_key_file_get_string(key_conf, groups[i], "Mirror", NULL); + char *blacklist = g_key_file_get_string(key_conf, groups[i], "Blacklist", nullptr); + char *mirror = g_key_file_get_string(key_conf, groups[i], "Mirror", nullptr); - if (g_key_file_has_key(key_conf, groups[i], "Priority", NULL)) + if (g_key_file_has_key(key_conf, groups[i], "Priority", nullptr)) { repo = new Slackpkg (groups[i], mirror, i + 1, blacklist, - g_key_file_get_string_list(key_conf, groups[i], "Priority", NULL, NULL)); + g_key_file_get_string_list(key_conf, groups[i], "Priority", nullptr, nullptr)); } - else if (g_key_file_has_key(key_conf, groups[i], "IndexFile", NULL)) + else if (g_key_file_has_key(key_conf, groups[i], "IndexFile", nullptr)) { repo = new Dl (groups[i], mirror, i + 1, blacklist, - g_key_file_get_string(key_conf, groups[i], "IndexFile", NULL)); + g_key_file_get_string(key_conf, groups[i], "IndexFile", nullptr)); } if (repo) @@ -137,71 +143,18 @@ pk_backend_destroy(PkBackend *backend) curl_global_cleanup (); } -gchar ** -pk_backend_get_mime_types(PkBackend *backend) -{ - const gchar *mime_types[] = { - "application/x-xz-compressed-tar", - "application/x-compressed-tar", - "application/x-bzip-compressed-tar", - "application/x-lzma-compressed-tar", - NULL - }; - - return g_strdupv((gchar **) mime_types); -} - -gboolean -pk_backend_supports_parallelization(PkBackend *backend) -{ - return FALSE; -} - -const gchar * -pk_backend_get_description(PkBackend* backend) -{ - return "Slackware"; -} - -const gchar * -pk_backend_get_author(PkBackend* backend) -{ - return "Eugene Wissner <belka@caraus.de>"; -} - -PkBitfield -pk_backend_get_groups(PkBackend *backend) -{ - return pk_bitfield_from_enums(PK_GROUP_ENUM_COLLECTIONS, - PK_GROUP_ENUM_SYSTEM, - PK_GROUP_ENUM_ADMIN_TOOLS, - PK_GROUP_ENUM_PROGRAMMING, - PK_GROUP_ENUM_PUBLISHING, - PK_GROUP_ENUM_DOCUMENTATION, - PK_GROUP_ENUM_DESKTOP_KDE, - PK_GROUP_ENUM_LOCALIZATION, - PK_GROUP_ENUM_NETWORK, - PK_GROUP_ENUM_DESKTOP_OTHER, - PK_GROUP_ENUM_ACCESSORIES, - PK_GROUP_ENUM_DESKTOP_XFCE, - PK_GROUP_ENUM_GAMES, - PK_GROUP_ENUM_OTHER, - PK_GROUP_ENUM_UNKNOWN, - -1); -} - void pk_backend_start_job(PkBackend *backend, PkBackendJob *job) { - gchar *db_filename = NULL; + char *db_filename = nullptr; JobData *job_data = g_new0(JobData, 1); - pk_backend_job_set_allow_cancel(job, TRUE); - pk_backend_job_set_allow_cancel(job, FALSE); + pk_backend_job_set_allow_cancel(job, true); + pk_backend_job_set_allow_cancel(job, false); - db_filename = g_build_filename(LOCALSTATEDIR, "cache", "PackageKit", "metadata", "metadata.db", NULL); + db_filename = g_build_filename(LOCALSTATEDIR, "cache", "PackageKit", "metadata", "metadata.db", nullptr); if (sqlite3_open(db_filename, &job_data->db) == SQLITE_OK) { /* Some SQLite settings */ - sqlite3_exec(job_data->db, "PRAGMA foreign_keys = ON", NULL, NULL, NULL); + sqlite3_exec(job_data->db, "PRAGMA foreign_keys = ON", nullptr, nullptr, nullptr); } else { @@ -231,32 +184,32 @@ pk_backend_stop_job(PkBackend *backend, PkBackendJob *job) sqlite3_close(job_data->db); g_free(job_data); - pk_backend_job_set_user_data(job, NULL); + pk_backend_job_set_user_data(job, nullptr); } void -pk_backend_search_names(PkBackend *backend, PkBackendJob *job, PkBitfield filters, gchar **values) +pk_backend_search_names(PkBackend *backend, PkBackendJob *job, PkBitfield filters, char **values) { - pk_backend_job_thread_create(job, pk_backend_search_thread, (gpointer) "name", NULL); + pk_backend_job_thread_create(job, pk_backend_search_thread, (void *) "name", nullptr); } void -pk_backend_search_details(PkBackend *backend, PkBackendJob *job, PkBitfield filters, gchar **values) +pk_backend_search_details(PkBackend *backend, PkBackendJob *job, PkBitfield filters, char **values) { - pk_backend_job_thread_create(job, pk_backend_search_thread, (gpointer) "desc", NULL); + pk_backend_job_thread_create(job, pk_backend_search_thread, (void *) "desc", nullptr); } void -pk_backend_search_groups(PkBackend *backend, PkBackendJob *job, PkBitfield filters, gchar **values) +pk_backend_search_groups(PkBackend *backend, PkBackendJob *job, PkBitfield filters, char **values) { - pk_backend_job_thread_create(job, pk_backend_search_thread, (gpointer) "cat", NULL); + pk_backend_job_thread_create(job, pk_backend_search_thread, (void *) "cat", nullptr); } static void -pk_backend_search_files_thread(PkBackendJob *job, GVariant *params, gpointer user_data) +pk_backend_search_files_thread(PkBackendJob *job, GVariant *params, void *user_data) { - gchar **vals, *search; - gchar *query; + char **vals, *search; + char *query; sqlite3_stmt *stmt; PkInfoEnum ret; auto job_data = static_cast<JobData *> (pk_backend_job_get_user_data(job)); @@ -264,30 +217,30 @@ pk_backend_search_files_thread(PkBackendJob *job, GVariant *params, gpointer use pk_backend_job_set_status(job, PK_STATUS_ENUM_QUERY); pk_backend_job_set_percentage(job, 0); - g_variant_get(params, "(t^a&s)", NULL, &vals); + g_variant_get(params, "(t^a&s)", nullptr, &vals); search = g_strjoinv("%", vals); query = sqlite3_mprintf("SELECT (p.name || ';' || p.ver || ';' || p.arch || ';' || r.repo), p.summary, " "p.full_name FROM filelist AS f NATURAL JOIN pkglist AS p NATURAL JOIN repos AS r " "WHERE f.filename LIKE '%%%q%%' GROUP BY f.full_name", search); - if ((sqlite3_prepare_v2(job_data->db, query, -1, &stmt, NULL) == SQLITE_OK)) + if ((sqlite3_prepare_v2(job_data->db, query, -1, &stmt, nullptr) == SQLITE_OK)) { /* Now we're ready to output all packages */ while (sqlite3_step(stmt) == SQLITE_ROW) { - ret = is_installed((gchar*) sqlite3_column_text(stmt, 2)); + ret = is_installed((char*) sqlite3_column_text(stmt, 2)); if ((ret == PK_INFO_ENUM_INSTALLED) || (ret == PK_INFO_ENUM_UPDATING)) { pk_backend_job_package(job, PK_INFO_ENUM_INSTALLED, - (gchar*) sqlite3_column_text(stmt, 0), - (gchar*) sqlite3_column_text(stmt, 1)); + (char*) sqlite3_column_text(stmt, 0), + (char*) sqlite3_column_text(stmt, 1)); } else if (ret == PK_INFO_ENUM_INSTALLING) { pk_backend_job_package(job, PK_INFO_ENUM_AVAILABLE, - (gchar*) sqlite3_column_text(stmt, 0), - (gchar*) sqlite3_column_text(stmt, 1)); + (char*) sqlite3_column_text(stmt, 0), + (char*) sqlite3_column_text(stmt, 1)); } } sqlite3_finalize(stmt); @@ -303,21 +256,21 @@ pk_backend_search_files_thread(PkBackendJob *job, GVariant *params, gpointer use } void -pk_backend_search_files(PkBackend *backend, PkBackendJob *job, PkBitfield filters, gchar **values) +pk_backend_search_files(PkBackend *backend, PkBackendJob *job, PkBitfield filters, char **values) { - pk_backend_job_thread_create(job, pk_backend_search_files_thread, NULL, NULL); + pk_backend_job_thread_create(job, pk_backend_search_files_thread, nullptr, nullptr); } static void -pk_backend_get_details_thread(PkBackendJob *job, GVariant *params, gpointer user_data) +pk_backend_get_details_thread(PkBackendJob *job, GVariant *params, void *user_data) { - gchar **pkg_ids, *homepage = NULL; - gchar** tokens; + char **pkg_ids, *homepage = nullptr; + char** tokens; gsize i; GString *desc; GRegex *expr; GMatchInfo *match_info; - GError *err = NULL; + GError *err = nullptr; sqlite3_stmt *stmt; auto job_data = static_cast<JobData *> (pk_backend_job_get_user_data(job)); @@ -330,7 +283,7 @@ pk_backend_get_details_thread(PkBackendJob *job, GVariant *params, gpointer user "WHERE name LIKE @name AND r.repo LIKE @repo AND ext NOT LIKE 'obsolete'", -1, &stmt, - NULL) != SQLITE_OK)) { + nullptr) != SQLITE_OK)) { pk_backend_job_error_code(job, PK_ERROR_ENUM_CANNOT_GET_FILELIST, "%s", sqlite3_errmsg(job_data->db)); goto out; } @@ -343,7 +296,7 @@ pk_backend_get_details_thread(PkBackendJob *job, GVariant *params, gpointer user if (sqlite3_step(stmt) != SQLITE_ROW) goto out; - desc = g_string_new((gchar *) sqlite3_column_text(stmt, 0)); + desc = g_string_new((char *) sqlite3_column_text(stmt, 0)); /* Regular expression for searching a homepage */ expr = g_regex_new("(?:http|ftp):\\/\\/[[:word:]\\/\\-\\.]+[[:word:]\\/](?=\\.?$)", @@ -375,9 +328,9 @@ pk_backend_get_details_thread(PkBackendJob *job, GVariant *params, gpointer user /* Ready */ pk_backend_job_details(job, pkg_ids[0], - NULL, - NULL, - pk_group_enum_from_string((gchar *) sqlite3_column_text(stmt, 1)), + nullptr, + nullptr, + pk_group_enum_from_string((char *) sqlite3_column_text(stmt, 1)), desc->str, homepage, sqlite3_column_int(stmt, 2), @@ -386,7 +339,7 @@ pk_backend_get_details_thread(PkBackendJob *job, GVariant *params, gpointer user g_free(homepage); if (desc) { - g_string_free(desc, TRUE); + g_string_free(desc, true); } out: @@ -394,15 +347,15 @@ out: } void -pk_backend_get_details(PkBackend *backend, PkBackendJob *job, gchar **package_ids) +pk_backend_get_details(PkBackend *backend, PkBackendJob *job, char **package_ids) { - pk_backend_job_thread_create(job, pk_backend_get_details_thread, NULL, NULL); + pk_backend_job_thread_create(job, pk_backend_get_details_thread, nullptr, nullptr); } static void -pk_backend_resolve_thread(PkBackendJob *job, GVariant *params, gpointer user_data) +pk_backend_resolve_thread(PkBackendJob *job, GVariant *params, void *user_data) { - gchar **vals, **val; + char **vals, **val; sqlite3_stmt *stmt; PkInfoEnum ret; auto job_data = static_cast<JobData *> (pk_backend_job_get_user_data(job)); @@ -410,7 +363,7 @@ pk_backend_resolve_thread(PkBackendJob *job, GVariant *params, gpointer user_dat pk_backend_job_set_status(job, PK_STATUS_ENUM_QUERY); pk_backend_job_set_percentage(job, 0); - g_variant_get(params, "(t^a&s)", NULL, &vals); + g_variant_get(params, "(t^a&s)", nullptr, &vals); if ((sqlite3_prepare_v2(job_data->db, "SELECT (p1.name || ';' || p1.ver || ';' || p1.arch || ';' || r.repo), p1.summary, " @@ -419,7 +372,7 @@ pk_backend_resolve_thread(PkBackendJob *job, GVariant *params, gpointer user_dat "(SELECT MIN(p2.repo_order) FROM pkglist AS p2 WHERE p2.name = p1.name GROUP BY p2.name)", -1, &stmt, - NULL) == SQLITE_OK)) { + nullptr) == SQLITE_OK)) { /* Output packages matching each pattern */ for (val = vals; *val; val++) { @@ -427,18 +380,18 @@ pk_backend_resolve_thread(PkBackendJob *job, GVariant *params, gpointer user_dat while (sqlite3_step(stmt) == SQLITE_ROW) { - ret = is_installed((gchar*) sqlite3_column_text(stmt, 2)); + ret = is_installed((char*) sqlite3_column_text(stmt, 2)); if ((ret == PK_INFO_ENUM_INSTALLED) || (ret == PK_INFO_ENUM_UPDATING)) { pk_backend_job_package(job, PK_INFO_ENUM_INSTALLED, - (gchar*) sqlite3_column_text(stmt, 0), - (gchar*) sqlite3_column_text(stmt, 1)); + (char*) sqlite3_column_text(stmt, 0), + (char*) sqlite3_column_text(stmt, 1)); } else if (ret == PK_INFO_ENUM_INSTALLING) { pk_backend_job_package(job, PK_INFO_ENUM_AVAILABLE, - (gchar*) sqlite3_column_text(stmt, 0), - (gchar*) sqlite3_column_text(stmt, 1)); + (char*) sqlite3_column_text(stmt, 0), + (char*) sqlite3_column_text(stmt, 1)); } } @@ -454,16 +407,16 @@ pk_backend_resolve_thread(PkBackendJob *job, GVariant *params, gpointer user_dat } void -pk_backend_resolve(PkBackend *backend, PkBackendJob *job, PkBitfield filters, gchar **packages) +pk_backend_resolve(PkBackend *backend, PkBackendJob *job, PkBitfield filters, char **packages) { - pk_backend_job_thread_create(job, pk_backend_resolve_thread, NULL, NULL); + pk_backend_job_thread_create(job, pk_backend_resolve_thread, nullptr, nullptr); } static void -pk_backend_download_packages_thread(PkBackendJob *job, GVariant *params, gpointer user_data) +pk_backend_download_packages_thread(PkBackendJob *job, GVariant *params, void *user_data) { - gchar *dir_path, *path, **pkg_ids, *to_strv[] = {NULL, NULL}; - guint i; + char *dir_path, *path, **pkg_ids, *to_strv[] = {nullptr, nullptr}; + unsigned i; sqlite3_stmt *stmt; auto job_data = static_cast<JobData *> (pk_backend_job_get_user_data(job)); @@ -475,7 +428,7 @@ pk_backend_download_packages_thread(PkBackendJob *job, GVariant *params, gpointe "WHERE name LIKE @name AND ver LIKE @ver AND arch LIKE @arch AND repo LIKE @repo", -1, &stmt, - NULL) != SQLITE_OK)) + nullptr) != SQLITE_OK)) { pk_backend_job_error_code(job, PK_ERROR_ENUM_CANNOT_GET_FILELIST, "%s", sqlite3_errmsg(job_data->db)); goto out; @@ -483,7 +436,7 @@ pk_backend_download_packages_thread(PkBackendJob *job, GVariant *params, gpointe for (i = 0; pkg_ids[i]; ++i) { - gchar **tokens = pk_package_id_split(pkg_ids[i]); + char **tokens = pk_package_id_split(pkg_ids[i]); sqlite3_bind_text(stmt, 1, tokens[PK_PACKAGE_ID_NAME], -1, SQLITE_TRANSIENT); sqlite3_bind_text(stmt, 2, tokens[PK_PACKAGE_ID_VERSION], -1, SQLITE_TRANSIENT); @@ -496,12 +449,12 @@ pk_backend_download_packages_thread(PkBackendJob *job, GVariant *params, gpointe { pk_backend_job_package(job, PK_INFO_ENUM_DOWNLOADING, pkg_ids[i], - (gchar *) sqlite3_column_text(stmt, 0)); + (char *) sqlite3_column_text(stmt, 0)); static_cast<Pkgtools *> (repo->data)->download (job, dir_path, tokens[PK_PACKAGE_ID_NAME]); - path = g_build_filename(dir_path, (gchar *) sqlite3_column_text(stmt, 1), NULL); + path = g_build_filename(dir_path, (char *) sqlite3_column_text(stmt, 1), nullptr); to_strv[0] = path; - pk_backend_job_files(job, NULL, to_strv); + pk_backend_job_files(job, nullptr, to_strv); g_free(path); } } @@ -515,20 +468,20 @@ out: } void -pk_backend_download_packages(PkBackend *backend, PkBackendJob *job, gchar **package_ids, const gchar *directory) +pk_backend_download_packages(PkBackend *backend, PkBackendJob *job, char **package_ids, const char *directory) { - pk_backend_job_thread_create(job, pk_backend_download_packages_thread, NULL, NULL); + pk_backend_job_thread_create(job, pk_backend_download_packages_thread, nullptr, nullptr); } static void -pk_backend_install_packages_thread(PkBackendJob *job, GVariant *params, gpointer user_data) +pk_backend_install_packages_thread(PkBackendJob *job, GVariant *params, void *user_data) { - gchar *dest_dir_name; - gchar **pkg_ids; - guint i; + char *dest_dir_name; + char **pkg_ids; + unsigned i; gdouble percent_step; - GSList *install_list = NULL, *l; - sqlite3_stmt *pkglist_stmt = NULL, *collection_stmt = NULL; + GSList *install_list = nullptr, *l; + sqlite3_stmt *pkglist_stmt = nullptr, *collection_stmt = nullptr; PkBitfield transaction_flags = 0; PkInfoEnum ret; auto job_data = static_cast<JobData *> (pk_backend_job_get_user_data(job)); @@ -541,7 +494,7 @@ pk_backend_install_packages_thread(PkBackendJob *job, GVariant *params, gpointer "WHERE name LIKE @name AND ver LIKE @ver AND arch LIKE @arch AND repo LIKE @repo", -1, &pkglist_stmt, - NULL) != SQLITE_OK) || + nullptr) != SQLITE_OK) || (sqlite3_prepare_v2(job_data->db, "SELECT (c.collection_pkg || ';' || p.ver || ';' || p.arch || ';' || r.repo), p.summary, " "p.full_name, p.ext FROM collections AS c " @@ -550,7 +503,7 @@ pk_backend_install_packages_thread(PkBackendJob *job, GVariant *params, gpointer "WHERE c.name LIKE @name AND r.repo LIKE @repo", -1, &collection_stmt, - NULL) != SQLITE_OK)) + nullptr) != SQLITE_OK)) { pk_backend_job_error_code(job, PK_ERROR_ENUM_CANNOT_GET_FILELIST, "%s", sqlite3_errmsg(job_data->db)); goto out; @@ -558,7 +511,7 @@ pk_backend_install_packages_thread(PkBackendJob *job, GVariant *params, gpointer for (i = 0; pkg_ids[i]; i++) { - gchar **tokens = pk_package_id_split(pkg_ids[i]); + char **tokens = pk_package_id_split(pkg_ids[i]); sqlite3_bind_text(pkglist_stmt, 1, tokens[PK_PACKAGE_ID_NAME], -1, SQLITE_TRANSIENT); sqlite3_bind_text(pkglist_stmt, 2, tokens[PK_PACKAGE_ID_VERSION], -1, SQLITE_TRANSIENT); sqlite3_bind_text(pkglist_stmt, 3, tokens[PK_PACKAGE_ID_ARCH], -1, SQLITE_TRANSIENT); @@ -567,13 +520,13 @@ pk_backend_install_packages_thread(PkBackendJob *job, GVariant *params, gpointer if (sqlite3_step(pkglist_stmt) == SQLITE_ROW) { /* If it isn't a collection */ - if (g_strcmp0((gchar *) sqlite3_column_text(pkglist_stmt, 1), "collections")) + if (g_strcmp0((char *) sqlite3_column_text(pkglist_stmt, 1), "collections")) { if (pk_bitfield_contain(transaction_flags, PK_TRANSACTION_FLAG_ENUM_SIMULATE)) { pk_backend_job_package(job, PK_INFO_ENUM_INSTALLING, pkg_ids[i], - (gchar *) sqlite3_column_text(pkglist_stmt, 0)); + (char *) sqlite3_column_text(pkglist_stmt, 0)); } else { @@ -587,24 +540,24 @@ pk_backend_install_packages_thread(PkBackendJob *job, GVariant *params, gpointer while (sqlite3_step(collection_stmt) == SQLITE_ROW) { - ret = is_installed((gchar*) sqlite3_column_text(collection_stmt, 2)); + ret = is_installed((char*) sqlite3_column_text(collection_stmt, 2)); if ((ret == PK_INFO_ENUM_INSTALLING) || (ret == PK_INFO_ENUM_UPDATING)) { if ((pk_bitfield_contain(transaction_flags, PK_TRANSACTION_FLAG_ENUM_SIMULATE)) && - !g_strcmp0((gchar *) sqlite3_column_text(collection_stmt, 3), "obsolete")) + !g_strcmp0((char *) sqlite3_column_text(collection_stmt, 3), "obsolete")) { /* TODO: Don't just skip obsolete packages but remove them */ } else if (pk_bitfield_contain(transaction_flags, PK_TRANSACTION_FLAG_ENUM_SIMULATE)) { pk_backend_job_package(job, ret, - (gchar *) sqlite3_column_text(collection_stmt, 0), - (gchar *) sqlite3_column_text(collection_stmt, 1)); + (char *) sqlite3_column_text(collection_stmt, 0), + (char *) sqlite3_column_text(collection_stmt, 1)); } else { install_list = g_slist_append(install_list, - g_strdup((gchar *) sqlite3_column_text(collection_stmt, 0))); + g_strdup((char *) sqlite3_column_text(collection_stmt, 0))); } } } @@ -625,14 +578,14 @@ pk_backend_install_packages_thread(PkBackendJob *job, GVariant *params, gpointer /* Download the packages */ pk_backend_job_set_status(job, PK_STATUS_ENUM_DOWNLOAD); - dest_dir_name = g_build_filename(LOCALSTATEDIR, "cache", "PackageKit", "downloads", NULL); + dest_dir_name = g_build_filename(LOCALSTATEDIR, "cache", "PackageKit", "downloads", nullptr); for (l = install_list, i = 0; l; l = g_slist_next(l), i++) { - gchar **tokens; + char **tokens; GSList *repo; pk_backend_job_set_percentage(job, percent_step * i); - tokens = pk_package_id_split((gchar *)(l->data)); + tokens = pk_package_id_split((char *)(l->data)); repo = g_slist_find_custom(repos, tokens[PK_PACKAGE_ID_DATA], cmp_repo); if (repo) @@ -648,11 +601,11 @@ pk_backend_install_packages_thread(PkBackendJob *job, GVariant *params, gpointer pk_backend_job_set_status(job, PK_STATUS_ENUM_INSTALL); for (l = install_list; l; l = g_slist_next(l), i++) { - gchar **tokens; + char **tokens; GSList *repo; pk_backend_job_set_percentage(job, percent_step * i); - tokens = pk_package_id_split((gchar *)(l->data)); + tokens = pk_package_id_split((char *)(l->data)); repo = g_slist_find_custom(repos, tokens[PK_PACKAGE_ID_DATA], cmp_repo); if (repo) @@ -673,19 +626,19 @@ void pk_backend_install_packages(PkBackend *backend, PkBackendJob *job, PkBitfield transaction_flags, - gchar **package_ids) + char **package_ids) { - pk_backend_job_thread_create(job, pk_backend_install_packages_thread, NULL, NULL); + pk_backend_job_thread_create(job, pk_backend_install_packages_thread, nullptr, nullptr); } static void -pk_backend_remove_packages_thread(PkBackendJob* job, GVariant* params, gpointer user_data) +pk_backend_remove_packages_thread(PkBackendJob* job, GVariant* params, void *user_data) { - gchar **pkg_ids, *cmd_line; - guint i; + char **pkg_ids, *cmd_line; + unsigned i; gdouble percent_step; - gboolean allow_deps, autoremove; - GError *err = NULL; + bool allow_deps, autoremove; + GError *err = nullptr; PkBitfield transaction_flags = 0; g_variant_get(params, "(t^a&sbb)", &transaction_flags, &pkg_ids, &allow_deps, &autoremove); @@ -702,14 +655,14 @@ pk_backend_remove_packages_thread(PkBackendJob* job, GVariant* params, gpointer percent_step = 100.0 / g_strv_length(pkg_ids); for (i = 0; pkg_ids[i]; i++) { - gchar **tokens; + char **tokens; pk_backend_job_set_percentage(job, percent_step * i); tokens = pk_package_id_split(pkg_ids[i]); - cmd_line = g_strconcat("/sbin/removepkg ", tokens[PK_PACKAGE_ID_NAME], NULL); + cmd_line = g_strconcat("/sbin/removepkg ", tokens[PK_PACKAGE_ID_NAME], nullptr); /* Pkgtools return always 0 */ - g_spawn_command_line_sync(cmd_line, NULL, NULL, NULL, &err); + g_spawn_command_line_sync(cmd_line, nullptr, nullptr, nullptr, &err); g_free(cmd_line); g_strfreev(tokens); @@ -731,22 +684,22 @@ void pk_backend_remove_packages(PkBackend *backend, PkBackendJob *job, PkBitfield transaction_flags, - gchar **package_ids, - gboolean allow_deps, - gboolean autoremove) + char **package_ids, + bool allow_deps, + bool autoremove) { - pk_backend_job_thread_create(job, pk_backend_remove_packages_thread, NULL, NULL); + pk_backend_job_thread_create(job, pk_backend_remove_packages_thread, nullptr, nullptr); } static void -pk_backend_get_updates_thread(PkBackendJob *job, GVariant *params, gpointer user_data) +pk_backend_get_updates_thread(PkBackendJob *job, GVariant *params, void *user_data) { - gchar *pkg_id, *full_name, *desc; - const gchar *pkg_metadata_filename; + char *pkg_id, *full_name, *desc; + const char *pkg_metadata_filename; GFile *pkg_metadata_dir; GFileEnumerator *pkg_metadata_enumerator; GFileInfo *pkg_metadata_file_info; - GError *err = NULL; + GError *err = nullptr; sqlite3_stmt *stmt; auto job_data = static_cast<JobData *> (pk_backend_job_get_user_data(job)); @@ -759,7 +712,7 @@ pk_backend_get_updates_thread(PkBackendJob *job, GVariant *params, gpointer user "(SELECT MIN(p2.repo_order) FROM pkglist AS p2 WHERE p2.name = p1.name GROUP BY p2.name)", -1, &stmt, - NULL) != SQLITE_OK)) + nullptr) != SQLITE_OK)) { pk_backend_job_error_code(job, PK_ERROR_ENUM_CANNOT_GET_FILELIST, "%s", sqlite3_errmsg(job_data->db)); goto out; @@ -769,7 +722,7 @@ pk_backend_get_updates_thread(PkBackendJob *job, GVariant *params, gpointer user pkg_metadata_dir = g_file_new_for_path("/var/log/packages"); pkg_metadata_enumerator = g_file_enumerate_children(pkg_metadata_dir, "standard::name", G_FILE_QUERY_INFO_NONE, - NULL, + nullptr, &err); g_object_unref(pkg_metadata_dir); if (err) @@ -779,9 +732,9 @@ pk_backend_get_updates_thread(PkBackendJob *job, GVariant *params, gpointer user goto out; } - while ((pkg_metadata_file_info = g_file_enumerator_next_file(pkg_metadata_enumerator, NULL, NULL))) + while ((pkg_metadata_file_info = g_file_enumerator_next_file(pkg_metadata_enumerator, nullptr, nullptr))) { - gchar **tokens; + char **tokens; pkg_metadata_filename = g_file_info_get_name(pkg_metadata_file_info); tokens = split_package_name(pkg_metadata_filename); @@ -792,12 +745,12 @@ pk_backend_get_updates_thread(PkBackendJob *job, GVariant *params, gpointer user /* If there are more packages with the same name, remember the one from the * repository with the lowest order. */ if ((sqlite3_step(stmt) == SQLITE_ROW) - || g_slist_find_custom(repos, ((gchar *) sqlite3_column_text(stmt, 4)), cmp_repo)) + || g_slist_find_custom(repos, ((char *) sqlite3_column_text(stmt, 4)), cmp_repo)) { - full_name = g_strdup((gchar *) sqlite3_column_text(stmt, 0)); + full_name = g_strdup((char *) sqlite3_column_text(stmt, 0)); - if (!g_strcmp0((gchar *) sqlite3_column_text(stmt, 6), "obsolete")) + if (!g_strcmp0((char *) sqlite3_column_text(stmt, 6), "obsolete")) { /* Remove if obsolete */ pkg_id = pk_package_id_build(tokens[PK_PACKAGE_ID_NAME], tokens[PK_PACKAGE_ID_VERSION], @@ -807,7 +760,7 @@ pk_backend_get_updates_thread(PkBackendJob *job, GVariant *params, gpointer user * 1: Use the repository name instead of "obsolete" above and check in pk_backend_update_packages() if the package is obsolete or not * 2: Get description from /var/log/packages, not from the database */ - desc = g_strdup((gchar *) sqlite3_column_text(stmt, 5)); + desc = g_strdup((char *) sqlite3_column_text(stmt, 5)); pk_backend_job_package(job, PK_INFO_ENUM_REMOVING, pkg_id, desc); @@ -816,11 +769,11 @@ pk_backend_get_updates_thread(PkBackendJob *job, GVariant *params, gpointer user } else if (g_strcmp0(pkg_metadata_filename, full_name)) { /* Update available */ - pkg_id = pk_package_id_build((gchar *) sqlite3_column_text(stmt, 1), - (gchar *) sqlite3_column_text(stmt, 2), - (gchar *) sqlite3_column_text(stmt, 3), - (gchar *) sqlite3_column_text(stmt, 4)); - desc = g_strdup((gchar *) sqlite3_column_text(stmt, 5)); + pkg_id = pk_package_id_build((char *) sqlite3_column_text(stmt, 1), + (char *) sqlite3_column_text(stmt, 2), + (char *) sqlite3_column_text(stmt, 3), + (char *) sqlite3_column_text(stmt, 4)); + desc = g_strdup((char *) sqlite3_column_text(stmt, 5)); pk_backend_job_package(job, PK_INFO_ENUM_NORMAL, pkg_id, desc); @@ -845,14 +798,14 @@ out: void pk_backend_get_updates(PkBackend *backend, PkBackendJob *job, PkBitfield filters) { - pk_backend_job_thread_create(job, pk_backend_get_updates_thread, NULL, NULL); + pk_backend_job_thread_create(job, pk_backend_get_updates_thread, nullptr, nullptr); } static void -pk_backend_update_packages_thread(PkBackendJob *job, GVariant *params, gpointer user_data) +pk_backend_update_packages_thread(PkBackendJob *job, GVariant *params, void *user_data) { - gchar *dest_dir_name, *cmd_line, **pkg_ids; - guint i; + char *dest_dir_name, *cmd_line, **pkg_ids; + unsigned i; PkBitfield transaction_flags = 0; g_variant_get(params, "(t^a&s)", &transaction_flags, &pkg_ids); @@ -861,10 +814,10 @@ pk_backend_update_packages_thread(PkBackendJob *job, GVariant *params, gpointer pk_backend_job_set_status(job, PK_STATUS_ENUM_DOWNLOAD); /* Download the packages */ - dest_dir_name = g_build_filename(LOCALSTATEDIR, "cache", "PackageKit", "downloads", NULL); + dest_dir_name = g_build_filename(LOCALSTATEDIR, "cache", "PackageKit", "downloads", nullptr); for (i = 0; pkg_ids[i]; i++) { - gchar **tokens = pk_package_id_split(pkg_ids[i]); + char **tokens = pk_package_id_split(pkg_ids[i]); if (g_strcmp0(tokens[PK_PACKAGE_ID_DATA], "obsolete")) { @@ -885,7 +838,7 @@ pk_backend_update_packages_thread(PkBackendJob *job, GVariant *params, gpointer pk_backend_job_set_status(job, PK_STATUS_ENUM_UPDATE); for (i = 0; pkg_ids[i]; i++) { - gchar **tokens = pk_package_id_split(pkg_ids[i]); + char **tokens = pk_package_id_split(pkg_ids[i]); if (g_strcmp0(tokens[PK_PACKAGE_ID_DATA], "obsolete")) { @@ -901,8 +854,8 @@ pk_backend_update_packages_thread(PkBackendJob *job, GVariant *params, gpointer { /* Remove obsolete package * TODO: Removing should be an independent operation (not during installing updates) */ - cmd_line = g_strconcat("/sbin/removepkg ", tokens[PK_PACKAGE_ID_NAME], NULL); - g_spawn_command_line_sync(cmd_line, NULL, NULL, NULL, NULL); + cmd_line = g_strconcat("/sbin/removepkg ", tokens[PK_PACKAGE_ID_NAME], nullptr); + g_spawn_command_line_sync(cmd_line, nullptr, nullptr, nullptr, nullptr); g_free(cmd_line); } g_strfreev(tokens); @@ -914,22 +867,22 @@ void pk_backend_update_packages(PkBackend *backend, PkBackendJob *job, PkBitfield transaction_flags, - gchar **package_ids) + char **package_ids) { - pk_backend_job_thread_create(job, pk_backend_update_packages_thread, NULL, NULL); + pk_backend_job_thread_create(job, pk_backend_update_packages_thread, nullptr, nullptr); } static void -pk_backend_refresh_cache_thread(PkBackendJob *job, GVariant *params, gpointer user_data) +pk_backend_refresh_cache_thread(PkBackendJob *job, GVariant *params, void *user_data) { - gchar *tmp_dir_name, *db_err, *path = NULL; - gint ret; - gboolean force; - GSList *file_list = NULL; - GFile *db_file = NULL; - GFileInfo *file_info = NULL; - GError *err = NULL; - sqlite3_stmt *stmt = NULL; + char *tmp_dir_name, *db_err, *path = nullptr; + int ret; + bool force; + GSList *file_list = nullptr; + GFile *db_file = nullptr; + GFileInfo *file_info = nullptr; + GError *err = nullptr; + sqlite3_stmt *stmt = nullptr; auto job_data = static_cast<JobData *> (pk_backend_job_get_user_data(job)); pk_backend_job_set_status(job, PK_STATUS_ENUM_DOWNLOAD_CHANGELOG); @@ -948,9 +901,9 @@ pk_backend_refresh_cache_thread(PkBackendJob *job, GVariant *params, gpointer us /* Force the complete cache refresh if the read configuration file is newer than the metadata cache */ if (!force) { - path = g_build_filename(LOCALSTATEDIR, "cache", "PackageKit", "metadata", "metadata.db", NULL); + path = g_build_filename(LOCALSTATEDIR, "cache", "PackageKit", "metadata", "metadata.db", nullptr); db_file = g_file_new_for_path(path); - file_info = g_file_query_info(db_file, "time::modified-usec", G_FILE_QUERY_INFO_NOFOLLOW_SYMLINKS, NULL, &err); + file_info = g_file_query_info(db_file, "time::modified-usec", G_FILE_QUERY_INFO_NOFOLLOW_SYMLINKS, nullptr, &err); if (err) { pk_backend_job_error_code(job, PK_ERROR_ENUM_NO_CACHE, "%s: %s", path, err->message); @@ -961,7 +914,7 @@ pk_backend_refresh_cache_thread(PkBackendJob *job, GVariant *params, gpointer us "SELECT value FROM cache_info WHERE key LIKE 'last_modification'", -1, &stmt, - NULL); + nullptr); if ((ret != SQLITE_OK) || ((ret = sqlite3_step(stmt)) != SQLITE_ROW)) { pk_backend_job_error_code(job, @@ -971,14 +924,14 @@ pk_backend_refresh_cache_thread(PkBackendJob *job, GVariant *params, gpointer us sqlite3_errstr(ret)); goto out; } - if ((guint32) sqlite3_column_int(stmt, 0) > g_file_info_get_attribute_uint32(file_info, "time::modified-usec")) + if ((std::uint32_t) sqlite3_column_int(stmt, 0) > g_file_info_get_attribute_uint32(file_info, "time::modified-usec")) { - force = TRUE; + force = true; } } if (force) /* It should empty all tables */ { - if (sqlite3_exec(job_data->db, "DELETE FROM repos", NULL, 0, &db_err) != SQLITE_OK) + if (sqlite3_exec(job_data->db, "DELETE FROM repos", nullptr, 0, &db_err) != SQLITE_OK) { pk_backend_job_error_code(job, PK_ERROR_ENUM_INTERNAL_ERROR, "%s", db_err); sqlite3_free(db_err); @@ -998,8 +951,8 @@ pk_backend_refresh_cache_thread(PkBackendJob *job, GVariant *params, gpointer us for (GSList *l = file_list; l; l = g_slist_next(l)) { - get_file(&job_data->curl, static_cast<gchar **> (l->data)[0], - static_cast<gchar **> (l->data)[1]); + get_file(&job_data->curl, static_cast<char **> (l->data)[0], + static_cast<char **> (l->data)[1]); } g_slist_free_full(file_list, (GDestroyNotify)g_strfreev); @@ -1029,43 +982,43 @@ out: } void -pk_backend_refresh_cache(PkBackend *backend, PkBackendJob *job, gboolean force) +pk_backend_refresh_cache(PkBackend *backend, PkBackendJob *job, bool force) { - pk_backend_job_thread_create(job, pk_backend_refresh_cache_thread, NULL, NULL); + pk_backend_job_thread_create(job, pk_backend_refresh_cache_thread, nullptr, nullptr); } static void -pk_backend_get_update_detail_thread(PkBackendJob *job, GVariant *params, gpointer user_data) +pk_backend_get_update_detail_thread(PkBackendJob *job, GVariant *params, void *user_data) { - guint i; - gchar **pkg_ids; + unsigned i; + char **pkg_ids; pk_backend_job_set_status(job, PK_STATUS_ENUM_QUERY); g_variant_get(params, "(^a&s)", &pkg_ids); - for (i = 0; pkg_ids[i] != NULL; i++) + for (i = 0; pkg_ids[i] != nullptr; i++) { pk_backend_job_update_detail (job, pkg_ids[i], - NULL, - NULL, - NULL, - NULL, - NULL, + nullptr, + nullptr, + nullptr, + nullptr, + nullptr, PK_RESTART_ENUM_NONE, - NULL, - NULL, + nullptr, + nullptr, PK_UPDATE_STATE_ENUM_STABLE, - NULL, - NULL); + nullptr, + nullptr); } } void -pk_backend_get_update_detail(PkBackend *backend, PkBackendJob *job, gchar **package_ids) +pk_backend_get_update_detail(PkBackend *backend, PkBackendJob *job, char **package_ids) { - pk_backend_job_thread_create(job, pk_backend_get_update_detail_thread, NULL, NULL); + pk_backend_job_thread_create(job, pk_backend_get_update_detail_thread, nullptr, nullptr); } PkBitfield |