Merge pull request #11 from pweaver/starwars_tests

Remaining Starwars Tests
This commit is contained in:
Danny Navarro 2016-07-11 19:33:48 -04:00 committed by GitHub
commit 2cc6b00051
4 changed files with 157 additions and 33 deletions

View File

@ -5,3 +5,4 @@ the library design, or somehow else. In order of appearance:
- [Danny Navarro](mailto:j@dannynavarro.net) - [@jdnavarro](https://github.com/jdnavarro) - [Danny Navarro](mailto:j@dannynavarro.net) - [@jdnavarro](https://github.com/jdnavarro)
- [Matthías Páll Gissurarson](mailto:mpg@mpg.is) - [@Tritlo](https://github.com/Tritlo) - [Matthías Páll Gissurarson](mailto:mpg@mpg.is) - [@Tritlo](https://github.com/Tritlo)
- [Sólrún Halla Einarsdóttir](mailto:she@mpg.is) - [@solrun](https://github.com/solrun) - [Sólrún Halla Einarsdóttir](mailto:she@mpg.is) - [@solrun](https://github.com/solrun)
- [Pweaver (Paul Weaver)] (mailto:paul@mordor.org) - [@pweaver](https://github.com/pweaver)

View File

@ -56,6 +56,9 @@ appearsIn :: Character -> [Int]
appearsIn (Left x) = _appearsIn . _droidChar $ x appearsIn (Left x) = _appearsIn . _droidChar $ x
appearsIn (Right x) = _appearsIn . _humanChar $ x appearsIn (Right x) = _appearsIn . _humanChar $ x
secretBackstory :: Character -> Text
secretBackstory = error "secretBackstory is secret."
luke :: Character luke :: Character
luke = Right luke' luke = Right luke'

View File

@ -18,6 +18,8 @@ import Test.StarWars.Schema
-- * Test -- * Test
-- See https://github.com/graphql/graphql-js/blob/master/src/__tests__/starWarsQueryTests.js -- See https://github.com/graphql/graphql-js/blob/master/src/__tests__/starWarsQueryTests.js
test :: TestTree test :: TestTree
test = testGroup "Star Wars Query Tests" test = testGroup "Star Wars Query Tests"
[ testGroup "Basic Queries" [ testGroup "Basic Queries"
@ -43,11 +45,11 @@ test = testGroup "Star Wars Query Tests"
$ object [ "data" .= object [ $ object [ "data" .= object [
"hero" .= object [ "hero" .= object [
"id" .= ("2001" :: Text) "id" .= ("2001" :: Text)
, "name" .= ("R2-D2" :: Text) , r2d2Name
, "friends" .= [ , "friends" .= [
object ["name" .= ("Luke Skywalker" :: Text)] object [lukeName]
, object ["name" .= ("Han Solo" :: Text)] , object [hanName]
, object ["name" .= ("Leia Organa" :: Text)] , object [leiaName]
] ]
] ]
]] ]]
@ -75,29 +77,29 @@ test = testGroup "Star Wars Query Tests"
"name" .= ("Luke Skywalker" :: Text) "name" .= ("Luke Skywalker" :: Text)
, "appearsIn" .= ["NEWHOPE","EMPIRE","JEDI" :: Text] , "appearsIn" .= ["NEWHOPE","EMPIRE","JEDI" :: Text]
, "friends" .= [ , "friends" .= [
object ["name" .= ("Han Solo" :: Text)] object [hanName]
, object ["name" .= ("Leia Organa" :: Text)] , object [leiaName]
, object ["name" .= ("C-3PO" :: Text)] , object [c3poName]
, object ["name" .= ("R2-D2" :: Text)] , object [r2d2Name]
] ]
] ]
, object [ , object [
"name" .= ("Han Solo" :: Text) hanName
, "appearsIn" .= [ "NEWHOPE","EMPIRE","JEDI" :: Text] , "appearsIn" .= [ "NEWHOPE","EMPIRE","JEDI" :: Text]
, "friends" .= [ , "friends" .= [
object ["name" .= ("Luke Skywalker" :: Text)] object [lukeName]
, object ["name" .= ("Leia Organa" :: Text)] , object [leiaName]
, object ["name" .= ("R2-D2" :: Text)] , object [r2d2Name]
] ]
] ]
, object [ , object [
"name" .= ("Leia Organa" :: Text) leiaName
, "appearsIn" .= [ "NEWHOPE","EMPIRE","JEDI" :: Text] , "appearsIn" .= [ "NEWHOPE","EMPIRE","JEDI" :: Text]
, "friends" .= [ , "friends" .= [
object ["name" .= ("Luke Skywalker" :: Text)] object [lukeName]
, object ["name" .= ("Han Solo" :: Text)] , object [hanName]
, object ["name" .= ("C-3PO" :: Text)] , object [c3poName]
, object ["name" .= ("R2-D2" :: Text)] , object [r2d2Name]
] ]
] ]
] ]
@ -111,9 +113,7 @@ test = testGroup "Star Wars Query Tests"
} }
|] |]
$ object [ "data" .= object [ $ object [ "data" .= object [
"human" .= object [ "human" .= object [lukeName]
"name" .= ("Luke Skywalker" :: Text)
]
] ]
]] ]]
, testCase "Luke ID with variable" . testQueryParams , testCase "Luke ID with variable" . testQueryParams
@ -127,7 +127,7 @@ test = testGroup "Star Wars Query Tests"
} }
|] |]
$ object [ "data" .= object [ $ object [ "data" .= object [
"human" .= object ["name" .= ("Luke Skywalker" :: Text)] "human" .= object [lukeName]
]] ]]
, testCase "Han ID with variable" . testQueryParams , testCase "Han ID with variable" . testQueryParams
(\v -> if v == "someId" (\v -> if v == "someId"
@ -140,7 +140,7 @@ test = testGroup "Star Wars Query Tests"
} }
|] |]
$ object [ "data" .= object [ $ object [ "data" .= object [
"human" .= object ["name" .= ("Han Solo" :: Text)] "human" .= object [hanName]
]] ]]
, testCase "Invalid ID" . testQueryParams , testCase "Invalid ID" . testQueryParams
(\v -> if v == "id" (\v -> if v == "id"
@ -152,7 +152,7 @@ test = testGroup "Star Wars Query Tests"
} }
} }
|] $ object ["data" .= object ["human" .= object ["name" .= Aeson.Null]], |] $ object ["data" .= object ["human" .= object ["name" .= Aeson.Null]],
"errors" .= (Aeson.toJSON [object ["message" .= ("field name not resolved." :: Text)]])] "errors" .= Aeson.toJSON [object ["message" .= ("field name not resolved." :: Text)]]]
-- TODO: This test is directly ported from `graphql-js`, however do we want -- TODO: This test is directly ported from `graphql-js`, however do we want
-- to mimic the same behavior? Is this part of the spec? Once proper -- to mimic the same behavior? Is this part of the spec? Once proper
-- exceptions are implemented this test might no longer be meaningful. -- exceptions are implemented this test might no longer be meaningful.
@ -167,9 +167,7 @@ test = testGroup "Star Wars Query Tests"
} }
|] |]
$ object [ "data" .= object [ $ object [ "data" .= object [
"luke" .= object [ "luke" .= object [lukeName]
"name" .= ("Luke Skywalker" :: Text)
]
]] ]]
, testCase "R2-D2 ID and friends aliased" . testQuery , testCase "R2-D2 ID and friends aliased" . testQuery
[r| query HeroNameAndFriendsQuery { [r| query HeroNameAndFriendsQuery {
@ -185,7 +183,7 @@ test = testGroup "Star Wars Query Tests"
$ object [ "data" .= object [ $ object [ "data" .= object [
"hero" .= object [ "hero" .= object [
"id" .= ("2001" :: Text) "id" .= ("2001" :: Text)
, "name" .= ("R2-D2" :: Text) , r2d2Name
, "friends" .= [ , "friends" .= [
object ["friendName" .= ("Luke Skywalker" :: Text)] object ["friendName" .= ("Luke Skywalker" :: Text)]
, object ["friendName" .= ("Han Solo" :: Text)] , object ["friendName" .= ("Han Solo" :: Text)]
@ -204,14 +202,135 @@ test = testGroup "Star Wars Query Tests"
} }
|] |]
$ object [ "data" .= object [ $ object [ "data" .= object [
"luke" .= object [ "luke" .= object [lukeName]
"name" .= ("Luke Skywalker" :: Text) , "leia" .= object [leiaName]
]
, "leia" .= object [
"name" .= ("Leia Organa" :: Text)
]
]] ]]
, testGroup "Fragments for complex queries"
[ testCase "Aliases to query for duplicate content" . testQuery
[r| query DuplicateFields {
luke: human(id: "1000") {
name
homePlanet
}
leia: human(id: "1003") {
name
homePlanet
}
}
|]
$ object [ "data" .= object [
"luke" .= object [lukeName, tatooine]
, "leia" .= object [leiaName, alderaan]
]]
, testCase "Fragment for duplicate content" . testQuery
[r| query UseFragment {
luke: human(id: "1000") {
...HumanFragment
}
leia: human(id: "1003") {
...HumanFragment
}
}
fragment HumanFragment on Human {
name
homePlanet
}
|]
$ object [ "data" .= object [
"luke" .= object [lukeName, tatooine]
, "leia" .= object [leiaName, alderaan]
]]
]
, testGroup "__typename"
[ testCase "R2D2 is a Droid" . testQuery
[r| query CheckTypeOfR2 {
hero {
__typename
name
}
}
|]
$ object ["data" .= object [
"hero" .= ["__typename" .= ("Droid" :: Text), r2d2Name]
]]
, testCase "Luke is a human" . testQuery
[r| query CheckTypeOfLuke {
hero(episode: EMPIRE) {
__typename
name
}
}
|]
$ object ["data" .= object [
"hero" .= ["__typename" .= ("Human" :: Text), lukeName]
]]
]
, testGroup "Errors in resolvers"
[ testCase "error on secretBackstory" . testQuery
[r| query HeroNameQuery {
hero {
name
secretBackstory
}
}
|]
$ object ["data" .= object [
"hero" .= [r2d2Name, secretBackstory]
]
, "errors" .= object [
"message" .= Aeson.toJSON [secretText]
, "path" .= Aeson.toJSON [[ "hero" :: Text, "secretBackstory" :: Text ]]
]]
, testCase "Error in a list" . testQuery
[r| query HeroNameQuery {
hero {
name
friends {
name
secretBackstory
}
}
}
|]
$ object ["data" .= object [
"hero" .= [r2d2Name, "friends" .= [
object [lukeName, secretBackstory]
, object [hanName, secretBackstory]
, object [leiaName, secretBackstory]
]]
]
, "errors" .= object [
"message" .= Aeson.toJSON [secretText, secretText, secretText]
, "path" .= Aeson.toJSON [secretPath 0, secretPath 1, secretPath 2]
]]
, testCase "error on secretBackstory with alias" . testQuery
[r| query HeroNameQuery {
mainHero: hero {
name
story: secretBackstory
}
}
|]
$ object ["data" .= object [
"mainHero" .= [r2d2Name, "story" .= ()]
]
, "errors" .= object [
"message" .= Aeson.toJSON [secretText]
, "path" .= Aeson.toJSON [[ "mainHero" :: Text, "story" :: Text ]]
]]
]
] ]
where
lukeName = "name" .= ("Luke Skywalker" :: Text)
leiaName = "name" .= ("Leia Organa" :: Text)
hanName = "name" .= ("Han Solo" :: Text)
r2d2Name = "name" .= ("R2-D2" :: Text)
c3poName = "name" .= ("C-3PO" :: Text)
tatooine = "homePlanet" .= ("Tatooine" :: Text)
alderaan = "homePlanet" .= ("Alderaan" :: Text)
secretBackstory = "secretBackstory" .= ()
secretText = "secretBackstory is secret" :: Text
secretPath n = ("hero", "friends", n, "secretBackstory") :: (Text, Text, Int, Text)
testQuery :: Text -> Aeson.Value -> Assertion testQuery :: Text -> Aeson.Value -> Assertion
testQuery q expected = graphql schema q @?= Just expected testQuery q expected = graphql schema q @?= Just expected

View File

@ -42,4 +42,5 @@ character char =
, Schema.scalar "name" $ name char , Schema.scalar "name" $ name char
, Schema.array "friends" $ character <$> getFriends char , Schema.array "friends" $ character <$> getFriends char
, Schema.enum "appearsIn" . traverse getEpisode $ appearsIn char , Schema.enum "appearsIn" . traverse getEpisode $ appearsIn char
, Schema.scalar "secretBackstory" $ secretBackstory char
] ]