Recursive types #16

New Issue

prescientmoon · 2024-10-08T04:22:58+02:00

prescientmoon commented

2024-10-08 04:22:58 +02:00

Hi!

Sometimes types might refer to themselves (think of __Type having a field ofType of type __Type, which is required for introspection). The easiest approach is to bound this recursiveness to a certain depth (I'm getting infinite loops unless I do that). Are those infinite loops to be expected, or is that something on my end? (asking so I know whether to spend more time trying to debug this)

Hi! Sometimes types might refer to themselves (think of `__Type` having a field `ofType` of type `__Type`, which is required for introspection). The easiest approach is to bound this recursiveness to a certain depth (I'm getting infinite loops unless I do that). Are those infinite loops to be expected, or is that something on my end? (asking so I know whether to spend more time trying to debug this)

belka commented

2024-10-10 22:46:23 +02:00

Sounds like a bug. I checked the schema of my GraphQL application and it doesn't seem to have recursive types, so I wouldn't notice.

Ideally the library shouldn't care about the depth of recursion, it's the problem of the schema author, but it depends on what causes the problem.

What do I have to do to reproduce this, define a schema with a recursive type and run some query against it?

Sounds like a bug. I checked the schema of my GraphQL application and it doesn't seem to have recursive types, so I wouldn't notice. Ideally the library shouldn't care about the depth of recursion, it's the problem of the schema author, but it depends on what causes the problem. What do I have to do to reproduce this, define a schema with a recursive type and run some query against it?

prescientmoon commented

2024-11-19 20:10:11 +01:00

@belka Hi! I was getting those errors when implementing an introspection system. I ended up memoizing the __Type resolver (that's the biggest offender) and limiting the depth to 30 (which should be enough for any serious app). I'm not sure what the simplest way to reproduce this would be, but I guess we can close it for now.

@belka Hi! I was getting those errors when implementing an introspection system. I ended up memoizing the `__Type` resolver (that's the biggest offender) and limiting the depth to 30 (which should be enough for any serious app). I'm not sure what the simplest way to reproduce this would be, but I guess we can close it for now.

prescientmoon closed this issue

2024-11-19 20:10:11 +01:00

Sign in to join this conversation.